Fix KeyError from defer + deletion #2958
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2875
Description
The fix for this is a lot simpler than I'd previously thought.
Because of
--defer
, it's possible that the--state
manifest has recorded some upstream nodes (independs_on
) that no longer exist in the current project. When that upstream node is a source or ephemeral model, it raised aKeyError
. The fix just required that, before we try to record an edge, we first check that the node being reported by the other manifest actually exists in our known set of project nodes.I wrote out one test case,
run_defer_deleted_upstream
, which involved an upstream ephemeral model that exists in the deferral manifest but not in the current project. I confirmed that this test raises aKeyError
without the one-line fix, and passes with it.Checklist
CHANGELOG.md
and added information about my change to the "dbt next" section.