Add retry of additional errors #2694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beckjake
suggested changes
Aug 11, 2020
There was a problem hiding this comment.
I have some suggestions on the mechanics of the error type checks (isinstance takes a tuple of types instead of requiring multiple calls), but otherwise this looks good to me!
As always, thanks for your contribution to dbt! Please remember to add yourself to the contributors list in the changelog as well.
Comment on lines
407
to
408
| for type in REOPENABLE_ERRORS: | ||
| if isinstance(error, type): |
There was a problem hiding this comment.
I think you can just do if isinstance(error, REOPENABLE_ERRORS) here, right?
Comment on lines
451
to
452
| for error_type in RETRYABLE_ERRORS: | ||
| if isinstance(error, error_type): |
There was a problem hiding this comment.
See above, I think this can just be if isinstance(error, RETRYABLE_ERRORS)
|
Thanks for the quick review! Believe I got the changes you requested @beckjake |
beckjake
approved these changes
Aug 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1579
Description
This is a follow-up to #1963 which I've been sitting on for a while, which adds a few more errors to the class of retryable errors in BigQuery, and re-opens a connection for some that involve a broken connection. Would love to get this out of our local patches :)
Checklist
CHANGELOG.mdand added information about my change to the "dbt next" section.