Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: dbt clean without profile #2649

Merged
merged 3 commits into from
Jul 27, 2020
Merged

Fix: dbt clean without profile #2649

merged 3 commits into from
Jul 27, 2020

Conversation

beckjake
Copy link
Contributor

resolves #2620

Description

Fix dbt clean to work without a profile, like dbt deps.

I also backported the azure pipelines fix from dev/marian-anderson, I'm tired of that Windows tests failing!

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt next" section.

@cla-bot cla-bot bot added the cla:yes label Jul 27, 2020
@beckjake beckjake changed the title Fix/dbt clean noprofile Fix: dbt clean without profile Jul 27, 2020
@beckjake beckjake force-pushed the fix/dbt-clean-noprofile branch from 0ce8c58 to de4f90b Compare July 27, 2020 17:11
@beckjake beckjake requested review from jtcohen6 and kwigley July 27, 2020 19:01
jtcohen6
jtcohen6 approved these changes Jul 27, 2020
View reviewed changes
Copy link
Contributor

@jtcohen6 jtcohen6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works like a charm!

CHANGELOG.md Outdated Show resolved Hide resolved
@beckjake @jtcohen6
Update CHANGELOG.md
0919c56 
Co-authored-by: Jeremy Cohen <[email protected]>
@beckjake beckjake merged commit 5b40cc4 into dev/0.17.2 Jul 27, 2020
@beckjake beckjake deleted the fix/dbt-clean-noprofile branch July 27, 2020 21:16
@jtcohen6 jtcohen6 mentioned this pull request Jul 28, 2020
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtcohen6 jtcohen6 jtcohen6 approved these changes

@kwigley kwigley kwigley approved these changes

Assignees
No one assigned
Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@beckjake @kwigley @jtcohen6