On bigquery, persist docs for seeds as well as tables/views #2601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beckjake
force-pushed
the
fix/bigquery-seed-descriptions
branch
from
bdd3e1a to
4cef1af
Compare
kwigley
reviewed
Jun 30, 2020
|
In hindsight, this branch probably should have had a better name, it's very compelling to delete it. I'll open an issue to not use this branch anymore. |
drewbanin
approved these changes
Jun 30, 2020
5 tasks
|
I am still not seeing descriptions persisted on seeds in BigQuery. Has this fallen through the cracks? |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2598
Description
I added a method, made it available, and called it from the code that creates seeds.
I added a test that runs
dbt seedand makes sure the values are persisted properly.Checklist
CHANGELOG.mdand added information about my change to the "dbt next" section.