Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hash local package name #2600

Merged
merged 2 commits into from
Jun 29, 2020
Merged

Hash local package name #2600

merged 2 commits into from
Jun 29, 2020

Conversation

clrcrl
Copy link
Contributor

@clrcrl clrcrl commented Jun 29, 2020

resolves #

Description

Ensure we hash local package names — this was a regression introduced in #2429

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt next" section.

@cla-bot cla-bot bot added the cla:yes label Jun 29, 2020
@clrcrl clrcrl requested a review from beckjake June 29, 2020 19:40
CHANGELOG.md Outdated
@@ -1,5 +1,8 @@
## dbt 0.17.1 (Release TBD)

### Fixes
- Hash name of local packages
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please link to this PR as well, otherwise lgtm

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ha, but how does one know the PR number before creating the PR 🤔

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two ways: I look at the highest existing PR/issue numbers and add 1, and then if someone opens one in the interim I fix it with a git commit --amend; git push -f. Alternatively, I open it as a draft, copy the issue number in to the changelog, and do the git commit --amend; git push -f before I ask for reviews. Both suck!

@clrcrl clrcrl merged commit e7298d6 into dev/0.17.1 Jun 29, 2020
@clrcrl clrcrl deleted the fix/package-tracking branch June 29, 2020 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants