Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ENTRYPOINT to use 'dbt' #2475

Merged

Conversation

dmateusp
Copy link
Contributor

@dmateusp dmateusp commented May 20, 2020

resolves #2470

This is a copy of #2471 targeting dev/octavius-catto after @beckjake pointed out it is a bugfix

Description

Change the entrypoint to be able to pass arguments and use DBT as it is used outside the container

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt next" section.

@cla-bot cla-bot bot added the cla:yes label May 20, 2020
@dmateusp
Copy link
Contributor Author

Just rebased it against the bugfix branch, updated the CHANGELOG and removed the Dockerfile changes @beckjake

@beckjake
Copy link
Contributor

beckjake commented May 20, 2020

I think you accidentally pulled in some tests from dev/marian-anderson in your changelog commit!

@dmateusp
Copy link
Contributor Author

and oops I included files I didn't mean to include

@dmateusp dmateusp force-pushed the dmateusp/fix_docker_entrypoints branch from bd601fd to 832d43e Compare May 20, 2020 14:24
@dmateusp
Copy link
Contributor Author

Should be good now!

Copy link
Contributor

@beckjake beckjake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, one last thing - can you also add a new Contributors: list to the changelog for this upcoming release that includes yourself? If you look further down the changelog you'll see it in the previous release, it's just your username and links to PRs. That way we can make sure we include you in the release notes!

@dmateusp
Copy link
Contributor Author

Added! Although the change is so small it feels undeserved 😆

Copy link
Contributor

@beckjake beckjake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to kick off the tests and then we'll merge this for 0.17.0. Thanks for your contribution, all contributions deserve credit!

@beckjake beckjake merged commit a8f8708 into dbt-labs:dev/octavius-catto May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants