In dbt run, log relations for the status line instead of explicit node info #2450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewbanin
approved these changes
May 14, 2020
This was referenced May 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves dbt-labs/dbt-spark#74
Description
Instead of looking at nodes, defer to the adapter plugin's ideas about them by creating a relation from the node. I preserved the "don't show databases if it matches the default credentials" behavior, because I know people care about that!
The benefit here is that on spark, no more preceding
.s in dbt's description of what it's building.I would love to get this in for 0.17.0 if we can justify it to ourselves.
Checklist
CHANGELOG.mdand added information about my change to the "dbt next" section.