-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add BigQuery option to define a maximum query cost limit #2427
Add BigQuery option to define a maximum query cost limit #2427
Conversation
- added basic unit test for maximum_bytes_billed
Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA. In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, don't hesitate to ping @drewbanin. CLA has not been signed by users: @haukeduden |
@drewbanin I signed the CLA, specifying my user name "haukeduden". I got the message "Your response has been recorded.", so I assume that it has worked. But the CLA verification still seems to fail. |
@cla-bot check |
The cla-bot has been summoned, and re-checked this pull request! |
@haukeduden our cla-bot stuff requires manual intervention, unfortunately. This looks good to me, though flake8 seems upset about some things based on the failing tests. Please also add yourself to the changelog under "contributors" (just make a new section for the next release if there isn't one) so we can give you credit in the release notes! |
- added entry to contributors list
@beckjake I added the entry to contributors, as you asked, and fixed a whitespace issue that flake8 complained about. Sorry for not catching this before submitting. flake8 still fails, though -- but it complains about issues in files that have not been updated ( |
@haukeduden totally! I think if you pull in |
@beckjake I pulled the latest changes and that fixed the problem 👍. The tests pass now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thanks for contributing! I'll kick off the rest of the integration suite now
Merged! Thanks for your contribution @haukeduden -- this will ship in 0.17.0 :D |
resolves #2346
Description
This adds the option maximum_bytes_billed to BigQuery profiles. When this is set and not 0 then the corresponding query job option will be set. This is analogous to specifying
bq query --maximum_bytes_billed
on the commandline.Checklist
CHANGELOG.md
and added information about my change to the "dbt next" section.