Feature/bigquery column comments #2402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewbanin
force-pushed
the
feature/bigquery-column-comments
branch
from
078217b to
71cbc27
Compare
beckjake
reviewed
May 6, 2020
core/dbt/utils.py
Outdated
| @@ -631,3 +631,12 @@ def __getitem__(self, name: str) -> Any: | |||
|
|
|||
| def __contains__(self, name) -> bool: | |||
| return any((name in entry for entry in self._itersource())) | |||
|
|
|||
|
|
|||
| def sql_escape(string): | |||
There was a problem hiding this comment.
I think this is more of a weird bigquery thing than an "SQL" thing. Can this just go in the biguery impl.py?
drewbanin
force-pushed
the
feature/bigquery-column-comments
branch
from
3f37657 to
7122a3f
Compare
beckjake
approved these changes
May 7, 2020
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2335
Description
Adds docs persistence for BQ columns.
Checklist
CHANGELOG.mdand added information about my change to the "dbt next" section.