fix the ambiguous alias exception to respect databases #2387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The alias name check is now tied to the behavior of adapter.Relation.create_from(...) Plugins that override the `include` of their relations will use whatever they render to for the check the actual exception-raising code gets the name that was compared instead of generating its own Finally, I added a reasonable fallback behavior since this method was exposed to the context
|
Merging this before tests - just a changelog update |
|
This feature is currently blocking my team from launching dbt as we have multiple BigQuery biews with the same view name & dataset name but different project (database). Just curious about rough timeline for when this will be released in a new version of dbt? |
|
hi @azhard - this change will go out in our next release, dbt v0.17.0. We'll be cutting the first pre-release today, and the final release will be live at the end of the pre-release period (as soon as two weeks from now, but the exact date depends on how testing goes). |
|
That's awesome - thanks for the quick reply @drewbanin, really appreciate it! |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2326
Description
Fixes the ambiguous alias exception so now it respects databases
includeof their relations will use whatever they render to for the check the actual exception-raising code gets the name that was compared instead of generating its ownChecklist
CHANGELOG.mdand added information about my change to the "dbt next" section.