Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/handle query array types #2376

Merged
merged 1 commit into from
May 2, 2020
Merged

Fix/handle query array types #2376

merged 1 commit into from
May 2, 2020

Conversation

drewbanin
Copy link
Contributor

@drewbanin drewbanin commented Apr 29, 2020 •
edited
Loading

resolves #2337

Description

JSON-serialize nested data types in Postgres result sets.

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt next" section.

@drewbanin drewbanin requested a review from beckjake April 29, 2020 17:59
@cla-bot cla-bot bot added the cla:yes label Apr 29, 2020
beckjake
beckjake approved these changes Apr 29, 2020
View reviewed changes
Copy link
Contributor

@beckjake beckjake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This probably could use a test, but the change looks good and makes sense to me!

@drewbanin drewbanin force-pushed the fix/handle-query-array-types branch from 9298a9f to 0781cef Compare May 2, 2020 13:23
@drewbanin
Copy link
Contributor Author

fyi @beckjake test + changelog added, merging this one!

@drewbanin drewbanin merged commit 1f758f9 into dev/octavius-catto May 2, 2020
@drewbanin drewbanin deleted the fix/handle-query-array-types branch May 2, 2020 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beckjake beckjake beckjake approved these changes

Assignees
No one assigned
Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dbt Server errors when returning Array types in Postgres
2 participants
@drewbanin @beckjake