-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added warning to nodes selector if nothing was matched #2343
Added warning to nodes selector if nothing was matched #2343
Conversation
This will trigger a warning on any project that doesn't have sources (that's what the tests are failing about). I think this is a good feature, but I think we're going to have to change a bit more about how node selection works for this to function. I think we could change |
916bcc5
to
494c133
Compare
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: rjankowski.
|
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: rjankowski.
|
59d3361
to
a94a68c
Compare
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: rjankowski.
|
59b6720
to
3d0770b
Compare
3d0770b
to
c870969
Compare
Hi @beckjake. I've applied your suggestions and perform some refactors 😉 Feel free to reach out if you have any questions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, one little spelling-related nit and I can kick off the full test suite.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I'll kick off the test suite and then we'll get this merged for 0.17.0
resolves #2115
Description
Added warning (or error when
--warn-error
provided) when resource selector fails due to lack of resources for example when the incorrect model name was provided.Checklist
CHANGELOG.md
and added information about my change to the "dbt next" section.