Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect SKIP count in stdout #2310

Merged
merged 1 commit into from
Apr 14, 2020
Merged

Fix incorrect SKIP count in stdout #2310

merged 1 commit into from
Apr 14, 2020

Conversation

drewbanin
Copy link
Contributor

@drewbanin drewbanin commented Apr 9, 2020 •
edited
Loading

resolves #2095

Description

Fixes the logic around determining the number of skipped nodes in a run.

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt next" section.

@cla-bot cla-bot bot added the cla:yes label Apr 9, 2020
@drewbanin drewbanin force-pushed the fix/incorrect-skip-counts branch from e5b004b to 96a3736 Compare April 14, 2020 16:30
@drewbanin drewbanin requested a review from beckjake April 14, 2020 16:46
beckjake
beckjake approved these changes Apr 14, 2020
View reviewed changes
Copy link
Contributor

@beckjake beckjake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@drewbanin drewbanin merged commit 4dc12c7 into dev/octavius-catto Apr 14, 2020
@drewbanin drewbanin deleted the fix/incorrect-skip-counts branch April 14, 2020 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beckjake beckjake beckjake approved these changes

Assignees
No one assigned
Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dbt run summary reports incorrect SKIP= numbers
2 participants
@drewbanin @beckjake