Fix an error in exception handling for duplicate macros (#2288) #2293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewbanin
reviewed
Apr 3, 2020
test/unit/test_exceptions.py
Outdated
| assert 'dbt-myadapter' in str(exc.value) | ||
| assert 'some_macro' in str(exc.value) | ||
| assert 'namespace "dbt"' in str(exc.value) | ||
| assert '("dbt" and "dbt-myadapter" are both in the "dbt" namespace)' |
There was a problem hiding this comment.
i think you're missing an in str(..) here?
Add a unit test
beckjake
force-pushed
the
fix/duplicate-plugin-macros
branch
from
dea30ae to
be0e12e
Compare
drewbanin
approved these changes
Apr 3, 2020
|
Merging before the current checks pass - the previous ones passed, this commit is just a CHANGELOG.md conflict |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2288
Description
Use
name, notnamespace(which does not exist), for the macro name. Added a test.Checklist
CHANGELOG.mdand added information about my change to the "dbt next" section.