Read filenames using case insensitive extension

[sumanau7]

resolves #1681

Description

1. FileSystemSearcher now finds all files ignoring the case of the extension.
2. Add warning if core config files are found with .yaml extension in the project.

Checklist

• I have signed the CLA
• I have run this code in development and it appears to resolve the stated issue
• This PR includes tests, or tests are not required/relevant for this PR
• I have updated the CHANGELOG.md and added information about my change to the "dbt next" section.

[cla-bot]

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, don't hesitate to ping @drewbanin.

CLA has not been signed by users: @sumanau7

[beckjake]

@cla-bot check

[cla-bot]

The cla-bot has been summoned, and re-checked this pull request!

[beckjake]

Thanks for your contribution @sumanau7! It looks like flake8 is unhappy with your changes, mostly line length things - once those are fixed, tests should work:

core/dbt/parser/schemas.py:139:80: E501 line too long (80 > 79 characters)
core/dbt/parser/schemas.py:140:80: E501 line too long (89 > 79 characters)
core/dbt/parser/schemas.py:141:80: E501 line too long (90 > 79 characters)
core/dbt/parser/schemas.py:142:80: E501 line too long (99 > 79 characters)

[beckjake]

You should be able to just return itertools.chain(yaml_files, yml_files). It won't be the most efficient thing in the world, but that's probably fine.

[sumanau7]

@beckjake Does the overall PR looks good to be merged, for the new warning added, is the file dbt/unit/test_parser.py right place to add the unit test for it ?

[beckjake]

I think this unit test looks good!

I think for the warning, this should get an integration test. The tests in test/integration/008_schema_tests_test are a sort of reasonable place to start. In particular, check out the TestQuotedSchemaTestColumns test, which makes use of the quote-required-models folder inn there. You'll want to do similar to that test:

• create a models folder for the test
• put a model ending with (.sql) in it. It can just be something like select 1 as id.
• put a schema.yml file with .yaml in there and declare a test on the model (probably just a unique test on id)
• make sure results = self.run_dbt(["run"], strict=False) passes and that len(results) == 1
• make sure results = self.run_dbt(["test"], strict=False) passes and that len(results) == 1
• make sure results = self.run_dbt(["run"]) fails with an error (because strict mode is enabled). You will probably have to use something like this:

with self.assertRaises(dbt.exceptions.Exception) as exc:
    self.run_dbt(["run"])
self.assertIn('yaml', str(exc.exception)

You'll also want to add a second test that does the same but uses a file ending in .SQL, I think. That test might have to get skipped on windows.

[beckjake]

I think instead of logger.warning, we want exceptions.warn_or_error here.

[beckjake]

@sumanau7 This is a great PR so far, thanks for your contribution! This PR definitely merits some tests (I don't want to regress and break this in the future!) and we have some internal conventions on how we handle warnings that I have suggestions on, but this is all very minor.

[cla-bot]

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Sumanau Sareen.
This is most likely caused by a git client misconfiguration; please make sure to:

1. check if your git client is configured with an email to sign commits git config --list | grep email
2. If not, set it up using git config --global user.email [email protected]
3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

[sumanau7]

@beckjake let me know if integration tests looks good, i will proceed to update changes in changelog

[beckjake]

Ok, thanks! I've kicked off tests again and I truly believe this is it, though no promises 😆

I appreciate you sticking with this, I know it's a pain!

[sumanau7]

Ok, thanks! I've kicked off tests again and I truly believe this is it, though no promises 😆

I appreciate you sticking with this, I know it's a pain!

Don't worry about it, you guys are the best.

[cla-bot]

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Sumanau Sareen.
This is most likely caused by a git client misconfiguration; please make sure to:

1. check if your git client is configured with an email to sign commits git config --list | grep email
2. If not, set it up using git config --global user.email [email protected]
3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

[beckjake]

This will make it into 0.17.0 when that's released. Thanks so much for contributing to dbt!