Make the contents of the raw blocks regex pattern non-greedy (#2241) #2252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue where a file with multiple raw blocks got treated as one _big_ one
- it extended from the first {% raw %} to the last {% endraw %}
|
Merging this before tests run - just resolved a CHANGELOG.md conflict |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2241
Description
This fixes an issue where a file with multiple raw blocks got treated as one big one, from the first
{% raw %}to the last{% endraw %}. The trick was to add a non-greedy qualifier to the regex pattern that matches raw block bodies. I also added a unit test.Checklist
CHANGELOG.mdand added information about my change to the "dbt next" section.