Fix issue with table databases/schemas/names becoming numbers (#2206) #2208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… strings if they look like numbers
drewbanin
approved these changes
Mar 17, 2020
5 tasks
5 tasks
4 tasks
5 tasks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2206
resolves #2175
Description
Forcibly convert all table databases, table schemas, and table names to strings.
An alternative I considered is changing how we execute macros (and subsequently turn a database cursor into an agate table) in order to avoid going database -> interpreted type -> text. That required some seriously invasive changes to how we execute macros, but is probably more correct.
Checklist
CHANGELOG.mdand added information about my change to the "dbt next" section.