Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attach cli vars to configs when they come in via the RPC server (#2092) #2104

Merged
merged 2 commits into from
Feb 11, 2020

Conversation

beckjake
Copy link
Contributor

@beckjake beckjake commented Feb 7, 2020

Fixes #2092

This fixes #2092 by attaching the parsed CLI vars to the config when running the "cli_args" RPC command. This has the downside of clobbering any arguments provided via dbt rpc --vars "{...}". Hopefully that's a sacrifice we're willing to make!

@cla-bot cla-bot bot added the cla:yes label Feb 7, 2020
@beckjake beckjake requested a review from drewbanin February 7, 2020 20:06
Copy link
Contributor

@drewbanin drewbanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, otherwise works great and LGTM!

core/dbt/task/rpc/cli.py Outdated Show resolved Hide resolved
Copy link
Contributor

@drewbanin drewbanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ship it!

@beckjake beckjake merged commit 099b487 into dev/barbara-gittings Feb 11, 2020
@beckjake beckjake deleted the fix/rpc-cli-vars-arguments branch February 28, 2020 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Command line variable ignored when supplied to command in server
2 participants