Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve errors on importing plugins (#2006) #2022

Merged
merged 1 commit into from
Jan 6, 2020

Conversation

beckjake
Copy link
Contributor

Fixes #2006

When the error is specifically about not being able to import the plugin because it was not found, indicate that
Otherwise log the original error stack trace at debug and re-raise it

When the error is about not being able to import the plugin, indicate that
Otherwise log the original error stack trace at debug and re-raise it
@cla-bot cla-bot bot added the cla:yes label Dec 23, 2019
@beckjake beckjake requested a review from drewbanin December 23, 2019 18:30
@beckjake
Copy link
Contributor Author

the azure tests failed because snowflake is slow today, so they timed out.

Copy link
Contributor

@drewbanin drewbanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

@beckjake beckjake merged commit 33b4e72 into dev/barbara-gittings Jan 6, 2020
@beckjake beckjake deleted the fix/better-plugin-import-errors branch January 6, 2020 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants