Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename "warehouse" config key to "snowflake_warehouse" (#1899) #1901

Merged

Conversation

beckjake
Copy link
Contributor

@beckjake beckjake commented Nov 7, 2019

rename "warehouse" config key to "snowflake_warehouse"

Also featuring:
update snowflake connection to handle new closed state properly
tests

@cla-bot cla-bot bot added the cla:yes label Nov 7, 2019
@beckjake beckjake force-pushed the fix/warehouse-to-snowflake-warehouse branch from c68154f to 552e5be Compare November 7, 2019 21:18
…me "warehouse" config key to "snowflake_warehouse", tests
@beckjake beckjake force-pushed the fix/warehouse-to-snowflake-warehouse branch from 552e5be to 9f2a707 Compare November 8, 2019 14:30
@beckjake beckjake requested a review from drewbanin November 8, 2019 15:55
Copy link
Contributor

@drewbanin drewbanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Ship it

@beckjake beckjake merged commit 235ec1e into dev/louisa-may-alcott Nov 8, 2019
@beckjake beckjake deleted the fix/warehouse-to-snowflake-warehouse branch November 8, 2019 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants