Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test python 3.8 #1886

Merged
merged 3 commits into from
Nov 4, 2019
Merged

Test python 3.8 #1886

merged 3 commits into from
Nov 4, 2019

Conversation

beckjake
Copy link
Contributor

@beckjake beckjake commented Nov 4, 2019

Revamp the test docker images to be more multi-version-friendly, build MUCH more quickly, and be smaller.
Add testing for python 3.8, since that's released now.
Bump psycopg to 2.8.4 - they build binary wheels now (this isn't really advertised), and it works properly with python 3.8.

@beckjake beckjake requested a review from drewbanin November 4, 2019 16:17
@cla-bot cla-bot bot added the cla:yes label Nov 4, 2019
@drewbanin drewbanin added this to the Louisa May Alcott milestone Nov 4, 2019
Copy link
Contributor

@drewbanin drewbanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Ship it

Jacob Beck added 3 commits November 4, 2019 14:58
use a PPA to get python versions instead of compiling them all
add python 3.8 tests to tox.ini and circleci.yml
update psycopg2 to 2.8.4 since they build binary wheels when possible now
@beckjake beckjake force-pushed the feature/test-python-3.8 branch from 9c8163d to 610c02a Compare November 4, 2019 21:59
@beckjake beckjake merged commit 2d0f938 into dev/louisa-may-alcott Nov 4, 2019
@beckjake beckjake deleted the feature/test-python-3.8 branch November 4, 2019 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants