add run-operation + snapshot to the RPC server (#1875) #1878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One thing to think about here: Should the method name be |
drewbanin
reviewed
Oct 31, 2019
There was a problem hiding this comment.
One comment here about the argument to snapshot, but otherwise this looks and works super well!
Should the method name be run_operation
I think there's merit to each approach -- I don't feel super strongly either way! Parity with the CLI seems like a stronger argument than parity with other RPC tasks IMO
| METHOD_NAME = 'snapshot' | ||
|
|
||
| def set_args(self, params: RPCCompileParameters) -> None: | ||
| self.args.models = self._listify(params.models) |
There was a problem hiding this comment.
I think the input to snapshot on the CLI is -s --select, not --models - can we update this accordingly?
added 2 commits
November 1, 2019 09:22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1875
snapshot+run-operationsupport.run-operation:In addition to the defaults of 'task_tags' and 'timeout' there are 2 parameters:
- macro: str (required)
- args: Dict[str, Any] (optional)
As in the CLI version, run operations return a
successboolean that indicates whether the macro raised an exception or not. They will only return anerrorobject if the request itself is somehow wrong. The result returned by the macro is discarded.snapshot:This has the same arguments as
compileandrun. It executes thedbt snapshottask.Both methods work via
cli_args.