Handle a number of bad failure-path behaviors (#1807) #1839
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1807
This is one of those bugs where I don't see the bad behavior anymore so I assume it's ok. This was hard to write tests for, I had to use our internal analytics project with 8 threads to reproduce the issue: I assume it needs a large and complex test case to trigger. And I don't know where I'd even pull debugging information from.
Anyway, my attempts at fixing the issue described: