Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

postgres: gracefully handle materialized views (#1698) #1833

Merged

Conversation

beckjake
Copy link
Contributor

Fixes #1698

When the cache is told to add a link between relations that don't exist, create the missing ones with type=RelationType.External. Previously dbt failed with a cache inconsistency error, but the cache is really just incomplete rather than inconsistent.

@cla-bot cla-bot bot added the cla:yes label Oct 15, 2019
add_link now creates a relation if it doesn't exist (as "external")
add/fix tests
@beckjake beckjake force-pushed the fix/postgres-external-materialized-views branch from c27edc7 to fee9382 Compare October 15, 2019 17:59
@beckjake beckjake requested a review from drewbanin October 15, 2019 18:03
Copy link
Contributor

@drewbanin drewbanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM

@beckjake beckjake merged commit d5824d9 into dev/louisa-may-alcott Oct 15, 2019
@beckjake beckjake deleted the fix/postgres-external-materialized-views branch October 15, 2019 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dbt should not crash when it sees Materialized Views
2 participants