Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update logging levels in printer.py to match the intent #1823

Merged
merged 1 commit into from
Oct 11, 2019
Merged

update logging levels in printer.py to match the intent #1823

merged 1 commit into from
Oct 11, 2019

Conversation

heisencoder
Copy link
Contributor

See #1818

@cla-bot
Copy link

cla-bot bot commented Oct 10, 2019

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, don't hesitate to ping @drewbanin.

CLA has not been signed by users: @heisencoder

@heisencoder
Copy link
Contributor Author

This CLA bot is new! I'm going to need to get an internal review before proceeding...

@heisencoder
Copy link
Contributor Author

I've gotten approval to sign the agreement, and have signed it. Is there anything else I need to do to kick off the cls-signed check again?

@drewbanin
Copy link
Contributor

Thanks @heisencoder! You should be all set now -- I'll kick off the tests :)

@cla-bot check

@cla-bot cla-bot bot added the cla:yes label Oct 11, 2019
@cla-bot
Copy link

cla-bot bot commented Oct 11, 2019

The cla-bot has been summoned, and re-checked this pull request!

@drewbanin drewbanin self-requested a review October 11, 2019 19:05
drewbanin
drewbanin approved these changes Oct 11, 2019
View reviewed changes
Copy link
Contributor

@drewbanin drewbanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM - thanks for contributing this PR @heisencoder! It will ship in 0.15.0 :D

@drewbanin drewbanin merged commit 2d100c3 into dbt-labs:dev/louisa-may-alcott Oct 11, 2019
@drewbanin drewbanin mentioned this pull request Oct 17, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewbanin drewbanin drewbanin approved these changes

Assignees
No one assigned
Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@heisencoder @drewbanin