docs generate RPC task (#1781) #1801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beckjake
force-pushed
the
feature/add-docs-generate-rpc
branch
from
90dff84 to
5061397
Compare
drewbanin
reviewed
Oct 4, 2019
ok. the issue is that we do generate a manifest.json but only during the RPC server's compilation, not during catalog generation. |
beckjake
force-pushed
the
feature/add-docs-generate-rpc
branch
from
4dd0d9d to
02feb69
Compare
beckjake
force-pushed
the
feature/add-docs-generate-rpc
branch
from
02feb69 to
2031e23
Compare
drewbanin
approved these changes
Oct 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1781
Implement docs generate for the RPC task. I went with
docs.generatefor the RPC call name, since.is allowed and it seems like a nice namespace separator. That way we can dodbt source snapshot-freshness->source.snapshot-freshnessin the future, and the mapping is reasonably straightforward.