Expose the cache in dbt's rendering contexts (#1683) #1770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beckjake
changed the title
drewbanin
reviewed
Sep 20, 2019
added 2 commits
September 20, 2019 14:05
make new cache manipulation methods mark the methods available to the sql context move cache manipulation into appropriate macros and methods update the changelog fix some type checking
Materializations now return a list of relations they added - those get added to the cache Updated existing materializations Added backwards compatibility support + a deprecation warning
beckjake
force-pushed
the
feature/expose-cache-to-materializations
branch
from
1946b2f to
145e0b2
Compare
drewbanin
reviewed
Sep 23, 2019
drewbanin
approved these changes
Sep 23, 2019
Include the actual docs link! Co-Authored-By: Drew Banin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1683
Expose some cache manipulation methods to materializations and macros. As part of that I moved around where we do our cache changes in dbt itself. This is a breaking change - I've updated the changelog accordingly.
I also spent some time/energy getting mypy happy with this part of the code.
I'm not sure, but it's possible that we should be stubbing these out during parsing with
@available.parse_noneinstead of just@available.