Fix flat graph generation bug (#1740) #1750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewbanin
approved these changes
Sep 16, 2019
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1740
This is currently against 0.14.latest, but it probably should go against a new 0.14.3 branch, right?
Make flat graph an attribute and build it during runtime initialization. This should avoid any issues where one thread is calling
manifest.to_flat_graph(which iterates over manifest.nodes) while something else is modifying manifest.nodes. Instead, just pre-generate it during runtime initialization, which should cover us for any tasks that use the manifest/generate contexts.I broke testing 0.14.x pretty badly in my local environment and don't really want to fix it, so just 🤞 on tests passing here!