Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

force-cleanup all adapter connections before exiting handle_and_check (#1271) #1749

Merged
merged 1 commit into from
Sep 13, 2019

Conversation

beckjake
Copy link
Contributor

Fixes #1271

Ensure that all adapter connections get cleaned up before we leave handle_and_check. I included interpret_results because I can imagine a world where that needs to connect to the database or something.

Hopefully log management and the profiler's __exit__ never need to access the database, though I really can't imagine that happening.

@beckjake beckjake requested a review from drewbanin September 13, 2019 17:39
@cla-bot cla-bot bot added the cla:yes label Sep 13, 2019
Copy link
Contributor

@drewbanin drewbanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! Including interpret_results is a really good call here. Gave this a spin locally - looks like it works really well! #shipit

@beckjake beckjake merged commit cd5d39d into dev/louisa-may-alcott Sep 13, 2019
@beckjake beckjake deleted the fix/close-connections-properly branch September 13, 2019 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unclosed connections prevent dbt from exiting on Snowflake with keepalives enabled
2 participants