New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for errant method call in error handler #1694

Merged

drewbanin merged 1 commit into dev/0.14.1 from fix/connection-name-snowflake

Aug 21, 2019

Contributor

drewbanin commented Aug 21, 2019

fixes #1693

Open to doing this differently, but this looked like the path of least resistance :)


          Fix for errant method call in error handler

89c4dbc

drewbanin requested a review from beckjake

August 21, 2019 00:36

cla-bot bot added the cla:yes label

beckjake approved these changes

View reviewed changes

Contributor

beckjake commented Aug 21, 2019

We could also move nice_connection_name into the connection manager but I don't think that's worth the effort for a little error handling.

drewbanin merged commit 84a9915 into dev/0.14.1

drewbanin deleted the fix/connection-name-snowflake branch

August 21, 2019 13:40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels