Updated injected_node.wrapped_sql for data tests

[mikaelene]

The data tests feature uses in-code-sql that does not support all databases. This is a fix for supporting more databases and custom adapters.

This should not effect currently supported databases in any way.

ref conversation on dbt slack: https://getdbt.slack.com/archives/C50NEBJGG/p1565962661033700

[cla-bot]

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, don't hesitate to ping @drewbanin.

CLA has not been signed by users: @mikaelene

[drewbanin]

Hey @mikaelene, thanks for the PR! I think we'll be able to slip this in for the 0.14.1 release. Let me kick off the tests here - this will be ready to merge when they pass.

Thanks also for filling out the CLA. You're the first person to make a PR since we added it - glad to see it's working well :D

@cla-bot check

[cla-bot]

The cla-bot has been summoned, and re-checked this pull request!

[drewbanin]

Looks like there's a formatting issue here:

core/dbt/compilation.py:137:80: E501 line too long (82 > 79 characters)

You can run

docker-compose run test tox -e flake8

locally to run the flake8 linter. I'll kick these tests off again once that's updated!

[cla-bot]

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: mikael.ene.
This is most likely caused by a git client misconfiguration; please make sure to:

1. check if your git client is configured with an email to sign commits git config --list | grep email
2. If not, set it up using git config --global user.email [email protected]
3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

[mikaelene]

Hi, I've updated now to support flake8

[mikaelene]

I am using another pc today and the cla-bot apparently didn't get my cla-email. I've updated my git-profile. Do I need to do a "dummy"-commit or something?

[drewbanin]

Thanks @mikaelene! You can ignore the cla issue - I see your signature... will check out why this bot is misbehaving offline.

Just kicked the tests off - will merge this when they pass :)

[drewbanin]

oops, looks like flake8 is still complaining, try changing the code to something like:

                injected_node.wrapped_sql = (
                    "select count(*) as errors "
                    "from (\n{test_sql}\n) sbq").format(
                        test_sql=injected_node.injected_sql)

[drewbanin]

hey @mikaelene - are you using Windows? It looks like every line in this file has changed - is that a line ending thing?

[mikaelene]

Crap!

I didn't see that. I am using both windows and mac and store my project on Dropbox. That might be the problem. Let me try again.

[mikaelene]

Looks better now right?

[drewbanin]

I'm still seeing +252 -251 :/

[mikaelene]

Still learning to git :-(. How about now?

[drewbanin]

Looks great, thanks @mikaelene! Kicking off the tests here - will merge this when they pass :)

[drewbanin]

merging! Thanks for your contribution @mikaelene :)

[mikaelene]

Wow. Finally got it right. :-)