archives: do not create existing schema (#758) #1398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewbanin
approved these changes
Apr 19, 2019
| @@ -84,6 +85,11 @@ def list_schemas(self, database): | |||
| include_all=True) | |||
| return [ds.dataset_id for ds in all_datasets] | |||
|
|
|||
| @available | |||
There was a problem hiding this comment.
does this mean that we'll need to do something similar for the Presto and Spark plugins?
There was a problem hiding this comment.
This @available exists to make the relation available to bq's macros so it can implement this macro, because on bigquery that functionality is implemented via the connection.
Spark is a SQLAdapter and so it already has the macro available. Though it does look like it's incomplete?
We currently don't support archives on presto, so we don't have to worry about that at all.
There was a problem hiding this comment.
hah, dang. Ok, thanks for the info, we can handle Spark separately from this for sure
drewbanin
approved these changes
Apr 22, 2019
beckjake
force-pushed
the
feature/archive-blocks-as-regex
branch
from
b00c824 to
416cc72
Compare
beckjake
force-pushed
the
feature/archive-no-create-existing-schema
branch
from
7a4dae4 to
cc4f285
Compare
|
No changes, just a rebase onto the other PR! |
beckjake
changed the base branch from
feature/archive-blocks-as-regex
to
dev/wilt-chamberlain
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #758
This is based on #1361
During archive creation, check if a schema exists before creating it.
We should probably cache the results of
list_schemasorcheck_schema_exists.