-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Snowflake Key Pair Authentication #1232
Add support for Snowflake Key Pair Authentication #1232
Conversation
Thanks for the PR @alexyer! I love this feature, but the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hazmat
is where the cryptography
library stores all the crytpo primitives people actually use because they want you to use higher-level constructs. This is just encoding/serialization so there is no higher level construct to use.
I don't think I've ever accomplished a single useful thing from that library without calling into hazmat
. This looks good to me.
@alexyer I gave this a spin locally and it works great! I'll kick off the full test suite and then I think we'll be good to merge :) |
@drewbanin great, thanks for the review! |
Looks like the tests failed on the |
Oops, my bad. I'll update my PR. |
6df8a73
to
5edeb1a
Compare
hey @alexyer - I just kicked off another build for this, and it looks like there's a minor error with the unit tests. I'd love to get this merged, let me know how I can help! |
This PR adds support for Snowflake Key Pair Authentication. Unit tests verify everything's getting passed through correctly.
5edeb1a
to
438b352
Compare
@drewbanin just a minor typo. Should be fixed now. |
Thanks @alexyer - merged :) |
This PR adds support for Snowflake Key Pair Authentication.
Unit tests verify everything's getting passed through correctly.