Only parse CSV files during "dbt seed" (#867) #1046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
October 5, 2018 14:12
drewbanin
approved these changes
Oct 9, 2018
| self.assertEqual(len(self.run_dbt(['run'])), 1) | ||
|
|
||
| # make sure 'dbt seed' fails, otherwise our test is invalid! | ||
| with self.assertRaises(CompilationException): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only parse csv files if the dbt command is 'seed'. If it's not a seed run, there's no need to load the agate table because only seed materializations actually use it, so just supply an empty table.
To make it possible to figure out what command we're in while we're way down in the loader, I attached the parsed arguments to the config object, which should be useful in general.