Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose state and defer arguments to RPC run method #2678

Closed
beckjake opened this issue Aug 3, 2020 · 1 comment
Closed

Expose state and defer arguments to RPC run method #2678

beckjake opened this issue Aug 3, 2020 · 1 comment
Labels
enhancement New feature or request rpc Issues related to dbt's RPC server state Stateful selection (state:modified, defer)
Milestone
Kiyoshi Kuromiya

Comments

@beckjake
Copy link
Contributor

beckjake commented Aug 3, 2020

Describe the feature

The new --state and --defer arguments are available via the CLI and the environment, but aren't available to RPC run method. It should be!

We should also add tests for using it via the RPC server - it happens to work for cli_args now, but that's just because of how that method handles arguments.

Describe alternatives you've considered

cli_args works with --state and --defer, so you can use that.

Who will this benefit?

RPC users.
@beckjake beckjake added enhancement New feature or request triage labels Aug 3, 2020
@jtcohen6 jtcohen6 removed the triage label Aug 3, 2020
@jtcohen6 jtcohen6 added this to the 0.19.0 milestone Aug 11, 2020
@beckjake beckjake mentioned this issue Sep 1, 2020
Merged
4 tasks
@jtcohen6 jtcohen6 added rpc Issues related to dbt's RPC server state Stateful selection (state:modified, defer) labels Sep 9, 2020
@jtcohen6
Copy link
Contributor

jtcohen6 commented Sep 9, 2020

Resolved by #2736

@jtcohen6 jtcohen6 closed this as completed Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request rpc Issues related to dbt's RPC server state Stateful selection (state:modified, defer)
Projects
None yet
Milestone
Kiyoshi Kuromiya
Development

No branches or pull requests
2 participants
@beckjake @jtcohen6