Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning should be surfaced if any part of the --models specification doesn't exist #2115

Closed
1 of 5 tasks
kingfink opened this issue Feb 10, 2020 · 3 comments · Fixed by #2343
Closed
1 of 5 tasks

Warning should be surfaced if any part of the --models specification doesn't exist #2115

kingfink opened this issue Feb 10, 2020 · 3 comments · Fixed by #2343
Labels
enhancement New feature or request good_first_issue Straightforward + self-contained changes, good for new contributors!

Comments

@kingfink
Copy link
Contributor

Describe the bug

A clear and concise description of what the bug is. What command did you run? What happened?

Assume model_a exists and model_b does not exist in a given dbt project.

If you run dbt run --models model_b you get an error: WARNING: Nothing to do....

If you run dbt run --models model_a model_b you don't get any error since one of the models exists.

It seems like it would make sense to surface an error like WARNING: Model specification matching model_b not found or something like that

Steps To Reproduce

In as much detail as possible, please provide steps to reproduce the issue. Sample data that triggers the issue, example model code, etc is all very helpful here.

See above

Expected behavior

A clear and concise description of what you expected to happen.

See above

Screenshots and log output

If applicable, add screenshots or log output to help explain your problem.

See above

System information

Which database are you using dbt with?

  • postgres
  • redshift
  • bigquery
  • snowflake
  • other (specify: ____________)

The output of dbt --version:

Running with dbt=0.15.0

The operating system you're using:

OSX

The output of python --version:

Python 3.7.4

Additional context

Add any other context about the problem here.

Definitely not an urgent problem, but figure it's a good one to mention

@kingfink kingfink added bug Something isn't working triage labels Feb 10, 2020
@drewbanin drewbanin added enhancement New feature or request and removed triage bug Something isn't working labels Feb 11, 2020
@drewbanin
Copy link
Contributor

Thanks for the report @kingfink - this is a good idea! We should make this a highly visible warning that can be raised to an error using the --warn-error flag

@drewbanin drewbanin added the good_first_issue Straightforward + self-contained changes, good for new contributors! label Feb 11, 2020
@drewbanin drewbanin added this to the Octavius Catto milestone Feb 27, 2020
@jeremyyeo
Copy link
Contributor

@drewbanin seems like this is somewhat related to #1765?

@drewbanin
Copy link
Contributor

ha! Thanks @jeremyyeo - I was looking for that one! Just closed #1765 in favor of this issue. Appreciate you digging for it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good_first_issue Straightforward + self-contained changes, good for new contributors!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants