Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add macros to depends_on list for nodes that can call macros #2082

Closed
drewbanin opened this issue Jan 31, 2020 · 0 comments · Fixed by #2103
Closed

Add macros to depends_on list for nodes that can call macros #2082

drewbanin opened this issue Jan 31, 2020 · 0 comments · Fixed by #2103
Labels
enhancement New feature or request

Comments

@drewbanin
Copy link
Contributor

Describe the feature

The depends_on list for model, snapshot, analysis, and data test nodes should include the list of macros that the node depends on. I think this was the behavior at some point in the past, but we never really used this information if it was previously supported. As a part of #2068, we're going to want to add macros to the docs site. Accordingly, we'll want to see the macros that a model depends on inline in the generated docs.

Longer term, I think we'll also want to see the macros that a macro depends on, but my instinct is that this would be substantially more involved than the equivalent work for nodes. If that's not the case, then that would be very worthwhile here as well.

Use cases

  • Documentation
@drewbanin drewbanin added the enhancement New feature or request label Jan 31, 2020
@drewbanin drewbanin modified the milestones: 0.15.2, Barbara Gittings Jan 31, 2020
beckjake added a commit that referenced this issue Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant