Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Stephen Girard] Catalog query does not quote the db name on Snowflake #1317

Closed
drewbanin opened this issue Feb 24, 2019 · 0 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@drewbanin
Copy link
Contributor

Issue

Issue description

Seen in the wild: dbt's catalog queries on (at least) Snowflake don't always quote relation parts correctly. Specifically, this was seen when generating the catalog for Sources. We've seen:

  • quotes inside of quotes (where table_schema = '"schema"')
  • missing quotes (where table_schema = schema)

TODO:

  • Reproduce on Snowflake
  • Determine if this can happen on other databases
  • Add tests for different quoting configs across databases
  • Make sure our documentation for how to supply source db/schema/identifier names is rock-solid

System information

The output of dbt --version:

0.13.0-a2
@drewbanin drewbanin added the bug Something isn't working label Feb 24, 2019
@drewbanin drewbanin added this to the Stephen Girard milestone Feb 24, 2019
@drewbanin drewbanin self-assigned this Feb 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant