Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade schema.yml to v2 #91

Merged
merged 6 commits into from
Nov 21, 2018
Merged

Upgrade schema.yml to v2 #91

merged 6 commits into from
Nov 21, 2018

Conversation

clrcrl
Copy link
Contributor

@clrcrl clrcrl commented Nov 21, 2018

Updated all the schema.yml files, and schema.yml examples to be V2 of the schema.
Had to update a couple of the schema tests in the integration tests to make them play nicely.

@clrcrl clrcrl requested a review from drewbanin November 21, 2018 16:43
@clrcrl clrcrl changed the title Schema.yml to v2 Upgrade schema.yml to v2 Nov 21, 2018
Copy link
Contributor

@drewbanin drewbanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor feedback, mostly around styling/naming/formatting/etc

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@drewbanin drewbanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@clrcrl clrcrl merged commit ff47e6d into master Nov 21, 2018
@clrcrl clrcrl deleted the schema-to-v2 branch November 21, 2018 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants