Option to export DAG as png. #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewbanin
reviewed
Jun 6, 2019
| }; | ||
| var png64 = cy.png(options); | ||
| var url = png64.replace(/^data:image\/[^;]+/, 'data:application/octet-stream'); | ||
| window.open(url); |
There was a problem hiding this comment.
This is a cool approach! Seems to work well, but it looks like the file is downloaded with the named download on Chrome? What do you think about using a link instead? I think something like this should work:
var link = document.createElement('a');
link.download = 'dbt-dag.png'; // sets the filename for the download
link.href = url;
link.click();
There was a problem hiding this comment.
Yes, I wasn't sure about the browser support (~82% support: https://caniuse.com/#feat=download), but I guess it's progressive enhancement. If the browser doesn't support it, it will use the default filename. There is some crash in Edge13 apparently, but that's probably not a big percentage.
|
Changes in @drewbanin Thanks for the review! 👍 |
1 task
|
Thanks @groodt! This is a really neat feature - super excited to merge it :) This is going out in dbt v0.14.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a context menu to the DAG that allows it to be exported as a PNG.
Fixes #29