Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added search by tag name #32

Merged
merged 3 commits into from
May 21, 2019
Merged

Added search by tag name #32

merged 3 commits into from
May 21, 2019

Conversation

rmgpinto
Copy link
Contributor

Added two changes:

  1. Search for tags (layout similar to search for columns);
  2. Tags are now clickable and navigate directly to a search of that tag name.

@rmgpinto rmgpinto changed the title Se Added search by tag name May 20, 2019
@rmgpinto
Copy link
Contributor Author

rmgpinto commented May 20, 2019

jaffle_shop needs to have tags to test this PR.
Added PR #16 to jaffle-shop.

@rmgpinto rmgpinto marked this pull request as ready for review May 20, 2019 14:11
@drewbanin
Copy link
Contributor

hey @rmgpinto - thanks for making that jaffle-shop update! You'll need to re-compile the jaffle-shop project and copy the resulting .json files into the data/ dir. We could automate this in the CI process, bit it's currently manual.

Let me know if you'd like a hand with that - happy to help!

@rmgpinto
Copy link
Contributor Author

If you wouldn't mind. I'm getting an error running dbt seed on jaffle_shop:

Runtime Error in seed raw_orders (data/raw_orders.csv)
  Cannot escape <class 'datetime.date'>

@drewbanin
Copy link
Contributor

I just merged this PR: #33

You should be able to pull in master to see tags in the CI build!

@rmgpinto
Copy link
Contributor Author

rmgpinto commented May 20, 2019

Thanks @drewbanin.
The CI build seems very nice, searching for st displays search on model name, columns and tags simultaneously.

Copy link
Contributor

@drewbanin drewbanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is wonderful! Thanks for making this PR @rmgpinto -- Approved, and slated for release in 0.14.0 (tracked in dbt/#1474)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants