Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proper cache for recursive operations #82

Closed
fishi0x01 opened this issue Feb 16, 2021 · 0 comments · Fixed by #84
Closed

Proper cache for recursive operations #82

fishi0x01 opened this issue Feb 16, 2021 · 0 comments · Fixed by #84
Assignees
@fishi0x01
Labels
enhancement New feature or request

Comments

@fishi0x01
Copy link
Owner

At the moment, all non-ambiguous paths trigger 2 queries in order to determine their type.

On recursive operations, most isAmbiguous() calls are actually repeated and redundant. Current simple cache implementation only works on client.List() calls.

We need a cache that can be used by all operations to avoid redundant queries.
@fishi0x01 fishi0x01 added the enhancement New feature or request label Feb 16, 2021
@fishi0x01 fishi0x01 self-assigned this Feb 16, 2021
This was referenced Feb 16, 2021
Draft
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fishi0x01 fishi0x01

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add thread-safe cache fishi0x01/vsh
1 participant
@fishi0x01