Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-zero return codes on error #49

Closed
fishi0x01 opened this issue Sep 26, 2020 · 0 comments · Fixed by #51
Closed

Non-zero return codes on error #49

fishi0x01 opened this issue Sep 26, 2020 · 0 comments · Fixed by #51
Assignees
Labels
bug Something isn't working

Comments

@fishi0x01
Copy link
Owner

Currently, the return code is always 0, also if a command failed.
To comply with unix best practices, in non-interactive mode return codes should be non-zero on error, e.g.,:

$ vsh -c "cat /does/not/exist"
$ echo $?
1
@fishi0x01 fishi0x01 added the bug Something isn't working label Sep 26, 2020
@fishi0x01 fishi0x01 self-assigned this Sep 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant