Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cp from v1 to v1 with data field in payload is considered as v2 #114

Open
LaSylv opened this issue Mar 26, 2024 · 2 comments · May be fixed by #117
Open

cp from v1 to v1 with data field in payload is considered as v2 #114

LaSylv opened this issue Mar 26, 2024 · 2 comments · May be fixed by #117

Comments

@LaSylv
Copy link

LaSylv commented Mar 26, 2024

When I use cp, the fields I'm copying have a data field, meaning the method isValidKV2Data (client/util.go:82) returns true, while it's still KV1 data, so it converts the data

I'll try to do an example test case
@fishi0x01
Copy link
Owner

Thank you for reporting this 🙇
I will create a test case in the near future

fishi0x01 added a commit that referenced this issue Apr 11, 2024
@fishi0x01
test for issue #114
65aeae8
@fishi0x01 fishi0x01 linked a pull request Apr 11, 2024 that will close this issue
Open
@fishi0x01
Copy link
Owner

@LaSylv I opened #117 with an example test case. However, it succeeds - can you elaborate please on how I can properly reproduce the issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#114 fix KV1 cp on data fishi0x01/vsh
2 participants
@fishi0x01 @LaSylv