Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tableheader of Creditmemo/Default.php is wrong #326

Closed
nige-one opened this issue Jun 13, 2016 · 5 comments
Closed

Tableheader of Creditmemo/Default.php is wrong #326

nige-one opened this issue Jun 13, 2016 · 5 comments
Labels

Comments

@nige-one
Copy link

Not sure why Creditmemo uses another Tableheader function _drawHeader then Invoice insertTableHeader. Anyway, it does not work correctly. After copying the content of insertTableHeader into _drawHeader everything works fine. I guess it's an legacy issue.

@sprankhub
Copy link
Member

The reason is that the columns of the invoice are configurable, whereas the columns of the creditmemo are not.

For me, this works perfectly fine. What exactly does not work? Do you have any error?

@nige-one
Copy link
Author

Try to change the column order. Although the creditmemo tableheader column order is currently fixed, the item rendering respects the configured column order so it does not match up.

@sprankhub sprankhub added the bug label Jun 13, 2016
@zuiko
Copy link

zuiko commented Sep 28, 2017

The solution is to take the same columns configuration for creditmemo than invoice. In my mind, there is no reason why they could be different...
Somme changes on /app/code/community/FireGento/Pdf/Model/Engine/Creditmemo/Default.php
in function _drawHeader as indicated by nige-one

@Schrank
Copy link
Member

Schrank commented Sep 28, 2017

I think step a) is to use the same, step b) to have a second/third configuration for creditmemo and shipping

@zuiko
Copy link

zuiko commented Sep 28, 2017

I agree,
who can do most can do least... Most often.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants