Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adding https in api_endpoint wasn't working for resource manager #198

Merged
merged 2 commits into from
Aug 18, 2022
Merged

fix: adding https in api_endpoint wasn't working for resource manager #198

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b58685
fix: adding https in api_endpoint wasn't working for resource manager
yuryfirebolt Aug 18, 2022
a668010
fix: autoflake
yuryfirebolt Aug 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/firebolt/service/manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
from firebolt.client.auth import Token, UsernamePassword
from firebolt.common import Settings
from firebolt.service.provider import get_provider_id
from firebolt.utils.util import fix_url_schema

DEFAULT_TIMEOUT_SECONDS: int = 60 * 2

Expand Down Expand Up @@ -43,7 +44,7 @@ def __init__(self, settings: Optional[Settings] = None):

self.client = Client(
auth=auth,
base_url=f"https://{ self.settings.server}",
base_url=fix_url_schema(self.settings.server),
account_name=self.settings.account_name,
api_endpoint=self.settings.server,
timeout=Timeout(DEFAULT_TIMEOUT_SECONDS),
Expand Down