Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add cancel and status queries to server-side async execution #192
feat: Add cancel and status queries to server-side async execution #192
Changes from 89 commits
cfd856b
321b021
370e5cf
6ad3be4
1bea472
bf7f1f1
4196204
7ff71a7
0bace5b
c69f585
15df8cc
bec0804
37f2373
cb04815
fc7d116
ec0fd55
f7b9d09
d2ae886
f77ba35
8cae1d2
95f5e4d
9d1f1ff
442c420
e76a545
224f7c4
9d20bba
f403673
16ed40d
b58f881
8753a99
3d1c5b2
1abaaa4
9d4ffe8
c9e8947
2ba105f
52bd72c
22e4540
3320495
aef7dff
65b61da
3a4655d
ba6fd52
e9c70f8
7671506
c3a02af
2bc20db
d482caf
04a9e2f
cc749a3
3650755
3a33790
e373cf0
18d8fbe
36d0bbe
50b89f9
66604c0
bdb1063
4888d3f
a37d250
6939e28
634541d
3278e94
f7dc846
4072793
8830361
df3709d
0e2c553
7a798be
b428ba9
3a98c18
e9f2fc4
98c3252
c840433
58807a2
99540ed
d8d6d8f
0ab70cc
3704b9a
18d7c83
8d4ce91
c93bc08
ef3b668
7ad25c9
b5efbf4
143b0bd
3090dc1
b24a263
923d931
316f50a
ad18500
51fb204
0e816a7
5398f77
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about adding a brief paragraph here explaining the differences between server-side async vs. client-side async?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ericf-firebolt I see you merged the PR, but what about this comment above?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean that it's similar to client-side async?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ericf-firebolt I see you merged the PR, but what about this comment above?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delete "created" in this sentence?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ericf-firebolt I see you merged the PR, but what about this comment above?