Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Fir 13300 allow providing generic auth #166

Merged
merged 13 commits into from
May 18, 2022
Merged

refactor: Fir 13300 allow providing generic auth #166

merged 13 commits into from
May 18, 2022

Conversation

stepansergeevitch
Copy link
Collaborator

Preparations for adding service accounts authentication method:

  • Create base Auth class, as well as separate classes for Username/Password and Token authentication
  • Allow to provide Auth object instead of raw credentials. Deprecate the last.
  • Remove api_endpoint from auth objects. It's now only stored in Client, which is responsible for updating authentication requests base url

@stepansergeevitch stepansergeevitch self-assigned this May 13, 2022
@stepansergeevitch stepansergeevitch changed the title Fir 13300 allow providing generic auth refactor: Fir 13300 allow providing generic auth May 13, 2022
@stepansergeevitch stepansergeevitch force-pushed the FIR-13300-allow-providing-generic-auth branch from fb9410c to 3a4f2ed Compare May 13, 2022 12:28
ptiurin
ptiurin approved these changes May 16, 2022
View reviewed changes
Copy link
Collaborator

@ptiurin ptiurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from minor comments, lgtm.

src/firebolt/client/auth/username_password.py Outdated Show resolved Hide resolved
tests/unit/client/auth/test_auth.py Outdated Show resolved Hide resolved
@stepansergeevitch stepansergeevitch force-pushed the FIR-13300-allow-providing-generic-auth branch from c1fecfe to 9c73ca8 Compare May 18, 2022 09:47
@sonarcloud
Copy link

sonarcloud bot commented May 18, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

96.0% 96.0% Coverage
0.0% 0.0% Duplication

@stepansergeevitch stepansergeevitch merged commit 8795dc2 into main May 18, 2022
@stepansergeevitch stepansergeevitch deleted the FIR-13300-allow-providing-generic-auth branch May 18, 2022 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptiurin ptiurin ptiurin approved these changes

@eg-firebolt eg-firebolt Awaiting requested review from eg-firebolt

@yuryfirebolt yuryfirebolt Awaiting requested review from yuryfirebolt

Assignees

@stepansergeevitch stepansergeevitch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stepansergeevitch @ptiurin