Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture Segments in Rewrites #252

Open
craylward opened this issue Feb 8, 2018 · 1 comment
Open

Capture Segments in Rewrites #252

craylward opened this issue Feb 8, 2018 · 1 comment

Comments

@craylward
Copy link

Is there any reason why rewrites wouldn't support adding segment captures just like redirects?

@feildmaster
Copy link

feildmaster commented Apr 29, 2019

There is no honest reason to not support segment captures in rewrites, however you can sort of get around that now using a cloud function (which adds more overhead for something that should be a simple lookup in the backend)

EDIT: Actually, looking at the code I noticed that redirects use a regular exp to test, bypassing minimatch... which would suggest regex is used completely but I know from experience on the live server that regex doesn't work (but I didn't test very extensively)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants