From 2d2ff0832271edcf6643d7fc5b1f5880644e4976 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ros=C3=A1rio=20Pereira=20Fernandes?= Date: Thu, 17 Sep 2020 16:23:35 +0200 Subject: [PATCH] chore: test modular android action --- .github/workflows/android.yml | 4 +++- .../samples/quickstart/admobexample/kotlin/MainActivity.kt | 2 ++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/.github/workflows/android.yml b/.github/workflows/android.yml index 6830c61b5..cad9b3603 100644 --- a/.github/workflows/android.yml +++ b/.github/workflows/android.yml @@ -20,7 +20,9 @@ jobs: - name: Copy mock google_services.json run: ./copy_mock_google_services_json.sh - name: Build with Gradle (Pull Request) - run: ./build_pull_request.sh + uses: rosariopfernandes/modular-android-action@v0.1 + with: + for-each-module: 'assembleDebug' if: github.event_name == 'pull_request' - name: Build with Gradle (Push) run: ./gradlew clean ktlint build diff --git a/admob/app/src/main/java/com/google/samples/quickstart/admobexample/kotlin/MainActivity.kt b/admob/app/src/main/java/com/google/samples/quickstart/admobexample/kotlin/MainActivity.kt index 272e6ed60..dfe27961b 100644 --- a/admob/app/src/main/java/com/google/samples/quickstart/admobexample/kotlin/MainActivity.kt +++ b/admob/app/src/main/java/com/google/samples/quickstart/admobexample/kotlin/MainActivity.kt @@ -44,6 +44,8 @@ class MainActivity : AppCompatActivity() { adView.loadAd(adRequest) // [END load_banner_ad] + // Please only build admob + // AdMob ad unit IDs are not currently stored inside the google-services.json file. // Developers using AdMob can store them as custom values in a string resource file or // simply use constants. Note that the ad units used here are configured to return only test